DDFFORM 812 burger menu #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasben
approved these changes
Jun 6, 2024
Whether or not the burgermenu should be shown/hidden is determined through the .has-burger-menu class on the html. When the desktop menu is hidden due to too many/too long menu items, the sidebar(mobile menu) should be visible, but this was not implemented originally. This should correct it so that when the burgermenu is shown, the sidebar should be visible. DDFFORM-812
Long menu item names were overflowing the sidebar menu container. This should prevent that from happening. DDFFORM-812
LasseStaus
force-pushed
the
DDFFORM-812-burger-menu
branch
2 times, most recently
from
830b9d7 to
b3a640b
Compare
non chromium browsers did not indicate that the the mobile menu button was in focus, unlike the other menu buttons. This was because the other buttons are either link or button elements. This should align that approach which the other buttons and ensure the mobile-menu button is visually indicatin that it is in focus. DDFFORM-812
LasseStaus
force-pushed
the
DDFFORM-812-burger-menu
branch
from
b3a640b to
adb857b
Compare
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
Jira : DDFFORM-812
cms pr: danskernesdigitalebibliotek/dpl-cms#1246
Description
This PR aims to ensure that the header-sidebar-nav(Menu toggled by the burgermenu) is shown, when the current menu being displayed on the site is the burgermenu.
Whenever the burgermenu is displayed and toggled/clicked, it should now shown the menu.
Also added a change to menu items cant overflow the sidebar container.
If chromatic is failing it should be unrelated to the issue.