DDFHER-96 - Add @media print to enable printing of articles in modals
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `@media print` CSS changes affect styles only during print.
kasperg
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
👍
I am not too happy about the result of this change. We went from a print version which only displays the content of the modal but also only displays the first page multiple time to a print version which displays the entire page including both the modal and the underlying content.
We have both tried to address this in multiple ways but without succeeding at a better result. We have decided to proceed with the suggested change for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-96
Description
This pull request adds
@media printCSS styles to our modal component to enable proper printing of articles displayed within modals. While this solution addresses the immediate issue, we might want to consider using a library likereact-to-printfor a more beautiful approach in the future.Screenshot of the result
print.pdf
Test
https://varnish.pr-1657.dpl-cms.dplplat01.dpl.reload.dk/work/work-of%3A870971-avis%3A89724244?type=artikel&modal=infomedia-modal-870971-avis%3A89724244