Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node to v20 #749

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Upgrade node to v20 #749

merged 3 commits into from
Oct 25, 2024

Conversation

JacobArrow
Copy link
Contributor

Link to issue

https://reload.atlassian.net/browse/DDFBRA-137

Description

This PR upgrades node to version 20.

Be aware that we temporarily need to run storybook with some extra node options as a workaround in v6.

Additional comments or questions

Run nvm install --lts and nvm use to get started with node 20.

Due to a change in the OpenSSL API in Node 17, storybook fails to run without openssl-legacy-provider.
This can be omitted by upgrading Storybook to version 7 or higher.

storybookjs/storybook#19692 (comment)
@JacobArrow JacobArrow requested review from spaceo and removed request for spaceo October 23, 2024 13:37
@JacobArrow JacobArrow requested review from spaceo and kasperg October 23, 2024 13:47
Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@JacobArrow JacobArrow removed the request for review from spaceo October 25, 2024 11:17
@JacobArrow JacobArrow merged commit 31fcb90 into develop Oct 25, 2024
8 checks passed
@JacobArrow JacobArrow deleted the DDFBRA-137-upgrade-node-v20 branch October 25, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants