DDFNEXT-220: Upgrade Storybook and Prettier #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Stylelint v15 stylelint-config-prettier is no longer needed as all style-related rules have been deprecated.
With Storybook 8.0 the build system now requires explicit configuration for CSS
These were accidentally removed in a previous commit while testing
Storybook will no longer automatically import CSS. Maybe flatpickr CSS should be imported globally at some point?
Chromatic has changed the way they handle viewports for stories. https://www.chromatic.com/docs/storybook/viewports/#migration-from-viewports-legacy-to-modes
JacobArrow
changed the title
JacobArrow
commented
Nov 7, 2024
kasperg
approved these changes
Nov 7, 2024
src/stories/Library/card-list-page/SearchResultPage.stories.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-161
Description
npx storybook@latest migrate.mdxfiles withnpx storybook@latest migrateargs: {}instead ofargTypes.defaultValue: {}@whitespace/storybook-addon-htmlBeware that the newest version of Storybook introduces some new React warnings while compiling.