refactor: route helper function and add unit tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasGross
requested review from
spaceo and
Adamik10
and removed request for
spaceo and
Adamik10
spaceo
approved these changes
Nov 12, 2024
| className="block space-y-3 lg:space-y-5" | ||
| href={resolveUrl({ type: "work", routeParams: { id: work.workId } })}> | ||
| <div> | ||
| <div className="relative flex aspect-4/5 h-auto w-full flex-col rounded-base bg-background-overlay px-[15%] pt-[15%]"> |
There was a problem hiding this comment.
Just curious:
Why are these classes added here?
I guess they don't have a role in url resolving? :)
lib/helpers/helper.routes.ts
Outdated
| // console.log(searchRoute) // Output: /search?query=test | ||
|
|
||
| function buildRoute(route: string, params?: RouteParams, query?: QueryParams): string { | ||
| export function buildRoute(route: string, params?: RouteParams, query?: QueryParams): string { |
There was a problem hiding this comment.
Consider putting the three parameters in an object, then it is easier to handle optional parameters and you don't need to specify undefined like here:
https://github.com/danskernesdigitalebibliotek/dpl-go/pull/40/files#diff-4e5726f5588ca037aa726de6816a68efcc47e8e4c64ea260599410ee23dcecb1R44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-159
Description
Refactored route helper function and add unit tests