feat: add UniLogin configuration query and update related services #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckend-og-persister-i-applikationen
Changes are coming to the unlogin handling and this is just noise right now.
No need to repeat configuration fetching outside of it.
…ntend-hent-konfig-objekt-fra-backend-og-persister-i-applikationen_config-loading-in-go-config Move dplcms config loading to the config system
spaceo
force-pushed
the
DDFBRA-97-frontend-hent-konfig-objekt-fra-backend-og-persister-i-applikationen
branch
from
e0fa340 to
f325e5b
Compare
By adding some extra typescript magic
spaceo
force-pushed
the
DDFBRA-97-frontend-hent-konfig-objekt-fra-backend-og-persister-i-applikationen
branch
from
f325e5b to
2f75108
Compare
Since Nextjs is a tricky beast and handles env variables differently dependeing of the use of "NEXT_PUBLIC_" and a wish to be clear of what is only available server side we introduce a "server-only." prefix in the configuration key notation. Furthermore a useGoConfig is introduced for loading config client side. It wont be abe to load the "server-only" configuration.
…ckend-og-persister-i-applikationen
Only load stuff when requested...
Since everything has been moved to config resolvers they are not needed anymore
We do not want to fetch when resolver code is evaluated.
For some reasons options where not added in dpl-cms fetcher.
spaceo
force-pushed
the
DDFBRA-97-frontend-hent-konfig-objekt-fra-backend-og-persister-i-applikationen
branch
from
5a25789 to
1fd4647
Compare
It is easier to handle just one goConfig function both server and client side. Also added 5 min cache of dpl cms config fetching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-97
Description
Add UniLogin configuration query and update related services