Ddfbra 217 opdater unilogin integration til at bruge seneste stil anvisninger cleaned up #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest changes in STIL Unilogin hast tightened security and we needed to change our use of openid-client accordingly. Luckily version 6 of it makes it easier.
Had problems deploying because the node process coul not write into .next/trace. Probably when activatting sourcemaps serverside. It is not pretty but this makes sure that it is possible.
ThomasGross
approved these changes
Nov 22, 2024
We can activate it when problems with cookie handling have been resolved in LAgoob
Skibidi Toilet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-217
Description
Implementing Unilogin flow with new openid-client
Using version 6 with PKCE support
We decided to move this into main although a header buffer size problem in Lagoon has not been solved - because we need it for further development, where we need authenticated sessions.