User can see material description #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This accessibility issue is now handled inside the <Badge/> comp directly now
- We have a story for both mobile and desktop for each component.
… match the design
…, WorkPageLayout, CoverPicture, and InfoBox components for improved organization and clarity
ThomasGross
reviewed
Dec 12, 2024
Comment on lines
+351
to
+353
| function ({ addVariant }: { addVariant: (name: string, generator: string) => void }) { | ||
| addVariant("not-first", "&:not(:first-child)") | ||
| }, |
There was a problem hiding this comment.
What does this code enable?
There was a problem hiding this comment.
Can we instead use space-y-7 on the parent? I like when spacing are defined one place the parent instead of applying it on each child. :)
There was a problem hiding this comment.
It's the other way around - we need the margin-top to be there on every <hr> that's not the first <hr>
There was a problem hiding this comment.
Let me show you what I mean tomorrow :)
ThomasGross
reviewed
Dec 16, 2024
Comment on lines
+351
to
+353
| function ({ addVariant }: { addVariant: (name: string, generator: string) => void }) { | ||
| addVariant("not-first", "&:not(:first-child)") | ||
| }, |
There was a problem hiding this comment.
Can we instead use space-y-7 on the parent? I like when spacing are defined one place the parent instead of applying it on each child. :)
Adamik10
deleted the
DDFBRA-169-bruger-skal-kunne-se-en-beskrivelse-af-materiale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-169
Description
This PR adds:
Screenshot of the result
Additional comments or questions
There's a bug when redirecting to the search using tag buttons (inside InfoBoxItem.tsx) where it doesn't really update the search. It has something to do with x-state so I'll need Mikkel to help.