Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change keydown handling in SearchInput component to navigate using input ref value #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: change keydown handling in SearchInput component to navigate using input ref value #89

wants to merge 1 commit into from

Conversation

ThomasGross
Copy link
Contributor

spaceo
spaceo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is approved. But a new problem has arisen, which is complete unrelated to this PR:
We have a failing check.
We need a way to:

  • Make sure .env.test is used in Cypress CI tests
  • Make sure NEXT_PUBLIC_GRAPHQL_SCHEMA_ENDPOINT_DPL_CMS and NEXT_PUBLIC_GRAPHQL_BASIC_TOKEN_DPL_CMS is defined in that file

I'll create a task for that.

@spaceo spaceo removed their assignment Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceo spaceo spaceo approved these changes

Assignees

@Adamik10 Adamik10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasGross @spaceo @Adamik10