Skip to content

Commit

Permalink
Refactor menuLogOutUrl to logoutUrl
Browse files Browse the repository at this point in the history
The urls are in general considered to be global and in this case it is a
url that is needed in different apps/contexts
  • Loading branch information
spaceo committed Oct 18, 2023
1 parent f843c31 commit 0fecf52
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/apps/menu/menu-logged-in/MenuLoggedInContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const MenuLoggedInContent: FC<MenuLoggedInContentProps> = ({ pageSize }) => {
const [loansSoonOverdue, setLoansSoonOverdue] = useState<number>(0);
const [reservationsReadyForPickup, setReservationsReadyForPickup] =
useState<number>(0);
const { menuViewYourProfileTextUrl, menuLogOutUrl } = useUrls();
const { menuViewYourProfileTextUrl, logoutUrl } = useUrls();

// Set user data
useEffect(() => {
Expand Down Expand Up @@ -171,7 +171,7 @@ const MenuLoggedInContent: FC<MenuLoggedInContentProps> = ({ pageSize }) => {
<div className="modal-profile__btn-logout mx-32">
<Link
className="btn-primary btn-filled btn-large arrow__hover--right-small"
href={menuLogOutUrl}
href={logoutUrl}
>
{t("menuLogOutText")}
</Link>
Expand Down
2 changes: 1 addition & 1 deletion src/apps/menu/menu.dev.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export default {
defaultValue: "Profile links",
control: { type: "text" }
},
menuLogOutUrl: {
logoutUrl: {
defaultValue: "/Logout",
control: { type: "text" }
},
Expand Down
2 changes: 1 addition & 1 deletion src/apps/menu/menu.entry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export interface MenuProps {
menuLogOutText: string;
loansSoonOverdueText: string;
loansOverdueText: string;
menuLogOutUrl: string;
logoutUrl: string;
thresholdConfig: string;
feeListDaysText: string;
menuLoginText: string;
Expand Down

0 comments on commit 0fecf52

Please sign in to comment.