Skip to content

Commit

Permalink
Remove window.location.reload(); from Reader
Browse files Browse the repository at this point in the history
I believe the issue isn't with the `useEffect` inside `Reader`, but rather with the modal logic itself. I have encountered similar issues with the `FindOnShelfModal`, where it doesn't load the second time. A ticket has been created for this issue: https://reload.atlassian.net/browse/DDFHER-140
  • Loading branch information
kasperbirch1 committed Nov 20, 2024
1 parent 5b1cd37 commit 55f89e3
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/components/reader-player/Reader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ const Reader = ({ identifier, orderId }: ReaderType) => {

return () => {
removeAppendedAssets();
// TODO: Temporary workaround to reload the page when the reader is closed.
// The issue seems to be related to browser caching the reader, preventing it from properly refreshing.
// Replace this with a better solution in the future.
window.location.reload();
};
}, [identifier, orderId]);

Expand Down

0 comments on commit 55f89e3

Please sign in to comment.