Add materialIsReservableFromAnotherLibrary to `useReservableFromAno…

…therLibrary`

 For better code readability

src/components/material/MaterialAvailabilityText/MaterialAvailabilityText.tsx

@@ -22,12 +22,12 @@ const MaterialAvailabilityText: React.FC<Props> = ({ manifestations }) => {
   const t = useText();
   const materialType = head(getMaterialTypes(manifestations));
   const isbns = getAllIdentifiers(manifestations);
-  const reservablePidsFromAnotherLibrary =
+  const { materialIsReservableFromAnotherLibrary } =
     useReservableFromAnotherLibrary(manifestations);
 
   if (hasCorrectAccessType(AccessTypeCode.Physical, manifestations)) {
     const pids = getAllPids(manifestations);
-    if (reservablePidsFromAnotherLibrary.length) {
+    if (materialIsReservableFromAnotherLibrary) {
       return (
         <MaterialAvailabilityTextParagraph>
           {t("reservableFromAnotherLibraryText")}

src/components/material/material-buttons/MaterialButtons.tsx

@@ -35,10 +35,10 @@ const MaterialButtons: FC<MaterialButtonsProps> = ({
   // articles appear as a part of journal/periodical publications and can't be
   // physically loaned for themseleves.
 
-  const reservablePidsFromAnotherLibrary =
+  const { materialIsReservableFromAnotherLibrary } =
     useReservableFromAnotherLibrary(manifestations);
 
-  if (reservablePidsFromAnotherLibrary.length > 0) {
+  if (materialIsReservableFromAnotherLibrary) {
     return (
       <MaterialButtonReservableFromAnotherLibrary
         size={size}

src/components/reservation/ReservationModalBody.tsx

@@ -129,9 +129,10 @@ export const ReservationModalBody = ({
     !!selectedPeriodical
   );
 
-  const reservablePidsFromAnotherLibrary = useReservableFromAnotherLibrary(
-    selectedManifestations
-  );
+  const {
+    reservablePidsFromAnotherLibrary,
+    materialIsReservableFromAnotherLibrary
+  } = useReservableFromAnotherLibrary(selectedManifestations);
 
   // If we don't have all data for displaying the view render nothing.
   if (!userResponse.data || !holdingsResponse.data) {
@@ -178,14 +179,14 @@ export const ReservationModalBody = ({
       );
     }
 
-    if (reservablePidsFromAnotherLibrary?.length > 0 && patron) {
+    if (materialIsReservableFromAnotherLibrary && patron) {
       const { patronId, name, emailAddress, preferredPickupBranch } = patron;
 
       // Save reservation to open order.
       mutateOpenOrder(
         {
           input: {
-            pids: [...reservablePidsFromAnotherLibrary],
+            pids: reservablePidsFromAnotherLibrary,
             pickUpBranch: selectedBranch
               ? removePrefixFromBranchId(selectedBranch)
               : removePrefixFromBranchId(preferredPickupBranch),
@@ -253,7 +254,7 @@ export const ReservationModalBody = ({
           <div>
             <div className="reservation-modal-submit">
               <MaterialAvailabilityTextParagraph>
-                {reservablePidsFromAnotherLibrary?.length > 0 ? (
+                {materialIsReservableFromAnotherLibrary ? (
                   t("reservableFromAnotherLibraryText")
                 ) : (
                   <StockAndReservationInfo
@@ -302,7 +303,7 @@ export const ReservationModalBody = ({
                   selectedBranch={selectedBranch}
                   selectBranchHandler={setSelectedBranch}
                   selectedInterest={
-                    reservablePidsFromAnotherLibrary?.length > 0 &&
+                    materialIsReservableFromAnotherLibrary &&
                     selectedInterest === null
                       ? Number(defaultInterestDaysForOpenOrder)
                       : selectedInterest

src/core/utils/useReservableFromAnotherLibrary.tsx

@@ -6,7 +6,10 @@ import { Pid } from "./types/ids";
 
 const useReservableFromAnotherLibrary = (
   manifestations: Manifestation[]
-): Pid[] => {
+): {
+  reservablePidsFromAnotherLibrary: Pid[];
+  materialIsReservableFromAnotherLibrary: boolean;
+} => {
   const config = useConfig();
   const { data: holdingsData } = useGetHoldings({
     faustIds: getAllFaustIds(manifestations),
@@ -16,14 +19,26 @@ const useReservableFromAnotherLibrary = (
   // If there is no holdings data or if there are holdings that are reservable, we return an empty array.
   // Because we use the array length to determine if we should show the button or not.
   if (holdingsData?.some(({ reservable }) => reservable === true)) {
-    return [];
+    return {
+      reservablePidsFromAnotherLibrary: [],
+      materialIsReservableFromAnotherLibrary: false
+    };
   }
 
-  return manifestations
+  const reservablePidsFromAnotherLibrary = manifestations
     .filter(({ catalogueCodes }) =>
       catalogueCodes?.otherCatalogues.some((code) => code.startsWith("OVE"))
     )
     .map(({ pid }) => pid);
+
+  const materialIsReservableFromAnotherLibrary = Boolean(
+    reservablePidsFromAnotherLibrary.length
+  );
+
+  return {
+    reservablePidsFromAnotherLibrary,
+    materialIsReservableFromAnotherLibrary
+  };
 };
 
 export default useReservableFromAnotherLibrary;

src/tests/unit/useReservableFromAnotherLibrary.test.tsx

@@ -73,7 +73,10 @@ describe("useReservableFromAnotherLibrary", () => {
     );
 
     act(() => {
-      expect(result.current).toEqual(["870970-basis:27721257"]);
+      expect(result.current.reservablePidsFromAnotherLibrary).toEqual([
+        "870970-basis:27721257"
+      ]);
+      expect(result.current.materialIsReservableFromAnotherLibrary).toBe(true);
     });
   });
 
@@ -103,7 +106,8 @@ describe("useReservableFromAnotherLibrary", () => {
     );
 
     act(() => {
-      expect(result.current).toEqual([]);
+      expect(result.current.reservablePidsFromAnotherLibrary).toEqual([]);
+      expect(result.current.materialIsReservableFromAnotherLibrary).toBe(false);
     });
   });
 });