Skip to content

Commit

Permalink
Renaming user profile and dashboard url and text props
Browse files Browse the repository at this point in the history
To follow our genral naming conventions
  • Loading branch information
spaceo committed Nov 23, 2023
1 parent 18b5aa2 commit 839783e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/apps/menu/menu-logged-in/MenuLoggedInContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const MenuLoggedInContent: FC<MenuLoggedInContentProps> = ({ pageSize }) => {
AuthenticatedPatronV6 | null | undefined
>();
const [feeCount, setFeeCount] = useState<number>(0);
const { menuViewYourProfileTextUrl, logoutUrl } = useUrls();
const { userProfileUrl, logoutUrl } = useUrls();

// Set user data
useEffect(() => {
Expand Down Expand Up @@ -76,10 +76,10 @@ const MenuLoggedInContent: FC<MenuLoggedInContentProps> = ({ pageSize }) => {
{userData?.patron?.name}
</div>
<Link
href={menuViewYourProfileTextUrl}
href={userProfileUrl}
className="link-tag modal-header__link color-secondary-gray"
>
{t("menuViewYourProfileText")}
{t("menuUserProfileUrlText")}
</Link>
</div>
{showNotifications && (
Expand Down
4 changes: 2 additions & 2 deletions src/apps/menu/menu.dev.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ export default {
defaultValue: "By",
control: { type: "text" }
},
menuViewYourProfileText: {
menuUserProfileUrlText: {
defaultValue: "My Account",
control: { type: "text" }
},
menuViewYourProfileTextUrl: {
userProfileUrl: {
defaultValue: "/YourProfile",
control: { type: "text" }
},
Expand Down
4 changes: 2 additions & 2 deletions src/apps/menu/menu.entry.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import { DeleteReservationModalArgs } from "../../core/storybook/deleteReservati
import { RenewalArgs } from "../../core/storybook/renewalArgs";

export interface MenuProps {
menuViewYourProfileText: string;
menuViewYourProfileTextUrl: string;
menuUserProfileUrlText: string;
userProfileUrl: string;
menuNavigationDataConfig: string;
menuNotificationLoansExpiredText: string;
menuNotificationLoansExpiredUrl: string;
Expand Down

0 comments on commit 839783e

Please sign in to comment.