Refactor logic to decide returning <NotificationComponent /> or null.

Centralize all `useNotificationMessage` related logic.
danskernesdigitalebibliotek · Oct 19, 2023 · 91a7cfa · 91a7cfa
1 parent f4e5619
commit 91a7cfa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/components/notification/NotificationComponent.tsx b/src/components/notification/NotificationComponent.tsx
@@ -2,13 +2,12 @@ import React from "react";
 import PromoBar from "../promo-bar/PromoBar";
 
 interface NotificationComponentProps {
-  notificationMessage: string | null;
+  notificationMessage: string;
 }
 
 const NotificationComponent: React.FC<NotificationComponentProps> = ({
   notificationMessage
 }) => {
-  if (!notificationMessage) return null;
   return <PromoBar text={notificationMessage} type="info" />;
 };
 

diff --git a/src/core/utils/useNotificationMessage.tsx b/src/core/utils/useNotificationMessage.tsx
@@ -28,7 +28,10 @@ export const useNotificationMessage = ({
   };
 
   return [
-    () => <NotificationComponent notificationMessage={notificationMessage} />,
+    () =>
+      notificationMessage ? (
+        <NotificationComponent notificationMessage={notificationMessage} />
+      ) : null,
     handleNotificationMessage
   ];
 };