Move translations used in multiple apps to global definition

src/apps/advanced-search/AdvancedSearch.dev.tsx

@@ -110,16 +110,6 @@ export default {
       },
       defaultValue: "Remove @title from favorites list"
     },
-    alertErrorCloseText: {
-      name: "Alert error close text",
-      defaultValue: "close",
-      control: { type: "text" }
-    },
-    alertErrorMessageText: {
-      name: "Alert error message text",
-      defaultValue: "An error occurred",
-      control: { type: "text" }
-    },
     loadingText: {
       name: "Loading",
       defaultValue: "Loading",
@@ -359,11 +349,6 @@ export default {
       name: "Advanced search filter - non-fiction",
       defaultValue: "Non-fiction",
       control: { type: "text" }
-    },
-    multiselectAllOptionText: {
-      name: "Multiselect - all option",
-      defaultValue: "All",
-      control: { type: "text" }
     }
   }
 } as ComponentMeta<typeof AdvancedSearchEntry>;

src/apps/advanced-search/AdvancedSearch.entry.tsx

@@ -10,8 +10,6 @@ import { GlobalEntryTextProps } from "../../core/storybook/globalTextArgs";
 
 interface AdvancedSearchEntryTextProps {
   addToFavoritesAriaLabelText: string;
-  alertErrorCloseText: string;
-  alertErrorMessageText: string;
   byAuthorText: string;
   etAlText: string;
   inSeriesText: string;
@@ -68,7 +66,6 @@ interface AdvancedSearchEntryTextProps {
   advancedSearchFilterOnlineText: string;
   advancedSearchFilterFictionText: string;
   advancedSearchFilterNonFictionText: string;
-  multiselectAllOptionText: string;
 }
 
 interface AdvancedSearchEntryConfigProps {

src/apps/create-patron-user-info/CreatePatron.dev.tsx

@@ -87,10 +87,6 @@ export default {
       defaultValue: "Phone number",
       control: { type: "text" }
     },
-    patronContactInfoBodyText: {
-      defaultValue: "Please enter contact information below",
-      control: { type: "text" }
-    },
     patronContactInfoHeaderText: {
       defaultValue: "Contact information",
       control: { type: "text" }

src/apps/create-patron-user-info/CreatePatron.entry.tsx

@@ -33,7 +33,6 @@ interface CreatePatronTextProps {
   createPatronInvalidSSNHeaderText: string;
   patronContactEmailCheckboxText: string;
   patronContactEmailLabelText: string;
-  patronContactInfoBodyText: string;
   patronContactInfoHeaderText: string;
   patronContactNameLabelText: string;
   patronContactPhoneCheckboxText: string;

src/apps/dashboard/dashboard.dev.tsx

@@ -72,10 +72,6 @@ export default {
       defaultValue: "To be returned soon",
       control: { type: "text" }
     },
-    loansNotOverdueText: {
-      defaultValue: "Longer return time",
-      control: { type: "text" }
-    },
     reservationsText: {
       defaultValue: "Reservations",
       control: { type: "text" }

src/apps/dashboard/dashboard.entry.tsx

@@ -37,7 +37,6 @@ export interface DashBoardProps {
   etAlText: string;
   feesText: string;
   loanListMaterialDaysText: string;
-  loansNotOverdueText: string;
   loansOverdueText: string;
   loansSoonOverdueText: string;
   materialAndAuthorText: string;

src/apps/favorites-list/FavoritesList.dev.tsx

@@ -53,11 +53,6 @@ export default {
       defaultValue: "Available",
       control: { type: "text" }
     },
-    availabilityUnavailableText: {
-      name: "Availability: unavailable text",
-      defaultValue: "Unavailable",
-      control: { type: "text" }
-    },
     favoritesListMaterialsText: {
       defaultValue: "@count materials",
       control: { type: "text" }

src/apps/favorites-list/FavoritesList.entry.tsx

@@ -13,7 +13,6 @@ interface FavoritesListConfigEntryProps {
 }
 interface FavoritesListTextEntryProps {
   availabilityAvailableText: string;
-  availabilityUnavailableText: string;
   favoritesListMaterialsText: string;
   favoritesListHeaderText: string;
   byAuthorText: string;

src/apps/fee-list/FeeList.tsx

@@ -114,7 +114,10 @@ const FeeList: FC = () => {
         </span>
         {!itemsPrePaymentChange && !itemsPostPaymentChange && (
           <>
-            <ListHeader header={<>{t("unpaidFeesText")}</>} amount={0} />
+            <ListHeader
+              header={<>{t("unpaidFeesFirstHeadlineText")}</>}
+              amount={0}
+            />
             <EmptyList
               classNames="mt-24"
               emptyListText={t("emptyFeeListText")}

src/apps/loan-list/list/loan-list.dev.tsx

@@ -209,10 +209,6 @@ export default {
     resultPagerStatusText: {
       defaultValue: "Showing @itemsShown out of @hitcount loans",
       control: { type: "text" }
-    },
-    groupModalGoToMaterialAriaLabelText: {
-      defaultValue: "Go to @label material details",
-      control: { type: "text" }
     }
   },
   decorators: [withQuery]

src/apps/loan-list/list/loan-list.entry.tsx

@@ -22,7 +22,6 @@ export interface LoanListEntryUrlProps {
 }
 
 interface LoanListEntryTextProps {
-  groupModalGoToMaterialAriaLabelText: string;
   loanListAriaLabelListButtonText: string;
   loanListAriaLabelStackButtonText: string;
   loanListDigitalLoansEmptyListText: string;

src/apps/material/material.dev.tsx

@@ -59,11 +59,6 @@ export default {
       defaultValue: "Available",
       control: { type: "text" }
     },
-    availabilityUnavailableText: {
-      name: "Availability: unavailable text",
-      defaultValue: "Unavailable",
-      control: { type: "text" }
-    },
     materialHeaderAllEditionsText: {
       name: "Text for the fiction edition text",
       defaultValue: "All editions",
@@ -307,11 +302,6 @@ export default {
       defaultValue: "Material is loaned out",
       control: { type: "text" }
     },
-    findOnShelfExpandButtonExplanationText: {
-      name: "Find on shelf expand button explanation text",
-      defaultValue: "This button opens a modal",
-      control: { type: "text" }
-    },
     materialIsIncludedText: {
       name: "Material is included",
       defaultValue: "This material doesn't count towards your loan quota",
@@ -738,16 +728,6 @@ export default {
       defaultValue: "Film adaptations",
       control: { type: "text" }
     },
-    alertErrorCloseText: {
-      name: "Alert error close text",
-      defaultValue: "close",
-      control: { type: "text" }
-    },
-    alertErrorMessageText: {
-      name: "Alert error message text",
-      defaultValue: "An error occurred",
-      control: { type: "text" }
-    },
     expandMoreText: {
       name: "Expand more text",
       defaultValue: "Expand more",

src/apps/material/material.entry.tsx

@@ -10,12 +10,9 @@ import { GlobalEntryTextProps } from "../../core/storybook/globalTextArgs";
 
 interface MaterialEntryTextProps {
   addToFavoritesAriaLabelText: string;
-  alertErrorCloseText: string;
-  alertErrorMessageText: string;
   alreadyReservedText: string;
   approveReservationText: string;
   availabilityAvailableText: string;
-  availabilityUnavailableText: string;
   blockedButtonText: string;
   cantReserveText: string;
   cantViewReviewText: string;
@@ -55,7 +52,6 @@ interface MaterialEntryTextProps {
   fictionNonfictionText: string;
   filmAdaptationsText: string;
   findOnBookshelfText: string;
-  findOnShelfExpandButtonExplanationText: string;
   findOnShelfModalCloseModalAriaLabelText: string;
   findOnShelfModalListFindOnShelfText: string;
   findOnShelfModalListItemCountText: string;

src/apps/patron-page/PatronPage.dev.tsx

@@ -78,10 +78,6 @@ export default {
       defaultValue: "End date",
       control: { type: "text" }
     },
-    pauseReservationModalBelowInputsTextText: {
-      defaultValue: "",
-      control: { type: "text" }
-    },
     pauseReservationModalLinkText: {
       defaultValue:
         "Read more about pausing reservertions and what that means here",
@@ -111,10 +107,6 @@ export default {
       defaultValue: "Contact information",
       control: { type: "text" }
     },
-    patronContactInfoBodyText: {
-      defaultValue: "",
-      control: { type: "text" }
-    },
     patronContactPhoneLabelText: {
       defaultValue: "Phone number",
       control: { type: "text" }

src/apps/patron-page/PatronPage.entry.tsx

@@ -32,15 +32,13 @@ interface PatronPageTextProps {
   patronPinSavedSuccessText: string;
   dateInputsStartDateLabelText: string;
   dateInputsEndDateLabelText: string;
-  pauseReservationModalBelowInputsTextText: string;
   pauseReservationModalLinkText: string;
   pauseReservationModalSaveButtonLabelText: string;
   pauseReservationModalCancelButtonLabelText: string;
   patronPageBasicDetailsHeaderText: string;
   patronPageBasicDetailsNameLabelText: string;
   patronPageBasicDetailsAddressLabelText: string;
   patronContactInfoHeaderText: string;
-  patronContactInfoBodyText: string;
   patronContactPhoneLabelText: string;
   patronContactPhoneCheckboxText: string;
   patronContactEmailLabelText: string;

src/apps/reservation-list/list/reservation-list.dev.tsx

@@ -237,10 +237,6 @@ export default {
       defaultValue: "End date",
       control: { type: "text" }
     },
-    pauseReservationModalBelowInputsTextText: {
-      defaultValue: "",
-      control: { type: "text" }
-    },
     pauseReservationModalLinkText: {
       defaultValue:
         "Read more about pausing reservertions and what that means here",

src/apps/reservation-list/list/reservation-list.entry.tsx

@@ -58,7 +58,6 @@ export interface ReservationListTextProps {
   pauseReservationModalCloseModalText: string;
   dateInputsStartDateLabelText: string;
   dateInputsEndDateLabelText: string;
-  pauseReservationModalBelowInputsTextText: string;
   pauseReservationModalLinkText: string;
   pauseReservationModalSaveButtonLabelText: string;
   pauseReservationModalCancelButtonLabelText: string;

src/apps/reservation-list/modal/pause-reservation/pause-reservation.tsx

@@ -121,7 +121,7 @@ const PauseReservation: FC<PauseReservationProps> = ({ id, user }) => {
         </form>
         <div className="modal-pause__text-link mt-24 color-secondary-gray">
           <p className="text-body-small-regular">
-            {t("pauseReservationModalBelowInputsTextText")}
+            {t("pauseReservationModalBelowInputsText")}
             <Link
               id="pause-reservation-info-link"
               href={pauseReservationInfoUrl}

src/apps/search-header/search-header.dev.tsx

@@ -13,16 +13,6 @@ export default {
   argTypes: {
     ...serviceUrlArgs,
     ...globalTextArgs,
-    alertErrorCloseText: {
-      name: "Alert error close text",
-      defaultValue: "close",
-      control: { type: "text" }
-    },
-    alertErrorMessageText: {
-      name: "Alert error message text",
-      defaultValue: "An error occurred",
-      control: { type: "text" }
-    },
     searchHeaderIconAltText: {
       name: "Alt text for search button image",
       defaultValue: "search icon",

src/apps/search-header/search-header.entry.tsx

@@ -6,8 +6,6 @@ import GlobalUrlEntryPropsInterface from "../../core/utils/types/global-url-prop
 import { GlobalEntryTextProps } from "../../core/storybook/globalTextArgs";
 
 export interface SearchHeaderTextProps {
-  alertErrorCloseText: string;
-  alertErrorMessageText: string;
   searchHeaderIconAltText?: string;
   searchHeaderInputLabelText?: string;
   inputPlaceholderText?: string;

src/apps/search-result/search-result.dev.tsx

@@ -210,16 +210,6 @@ export default {
       },
       defaultValue: "Remove @title from favorites list"
     },
-    alertErrorCloseText: {
-      name: "Alert error close text",
-      defaultValue: "close",
-      control: { type: "text" }
-    },
-    alertErrorMessageText: {
-      name: "Alert error message text",
-      defaultValue: "An error occurred",
-      control: { type: "text" }
-    },
     loadingText: {
       name: "Loading",
       defaultValue: "Loading",

src/apps/search-result/search-result.entry.tsx

@@ -11,8 +11,6 @@ import { GlobalEntryTextProps } from "../../core/storybook/globalTextArgs";
 interface SearchResultEntryTextProps {
   addMoreFiltersText: string;
   addToFavoritesAriaLabelText: string;
-  alertErrorCloseText: string;
-  alertErrorMessageText: string;
   byAuthorText: string;
   etAlText: string;
   facetAccessTypesText: string;

src/core/storybook/globalTextArgs.ts

@@ -8,10 +8,55 @@ export default {
     name: "Alert error message text",
     defaultValue: "An error occurred",
     control: { type: "text" }
+  },
+  multiselectAllOptionText: {
+    name: "Multiselect - all option",
+    defaultValue: "All",
+    control: { type: "text" }
+  },
+  groupModalGoToMaterialAriaLabelText: {
+    defaultValue: "Go to @label material details",
+    control: { type: "text" }
+  },
+  availabilityUnavailableText: {
+    name: "Availability: unavailable text",
+    defaultValue: "Unavailable",
+    control: { type: "text" }
+  },
+  loansNotOverdueText: {
+    defaultValue: "Longer return time",
+    control: { type: "text" }
+  },
+  patronContactInfoBodyText: {
+    defaultValue: "",
+    control: { type: "text" }
+  },
+  pauseReservationModalBelowInputsText: {
+    defaultValue: "",
+    control: { type: "text" }
+  },
+  materialDetailsCloseModalAriaLabelText: {
+    defaultValue: "Close material details modal",
+    control: {
+      type: "text"
+    }
+  },
+  findOnShelfExpandButtonExplanationText: {
+    name: "Find on shelf expand button explanation text",
+    defaultValue: "This button opens a modal",
+    control: { type: "text" }
   }
 };
 
 export interface GlobalEntryTextProps {
   alertErrorCloseText: string;
   alertErrorMessageText: string;
+  multiselectAllOptionText: string;
+  groupModalGoToMaterialAriaLabelText: string;
+  availabilityUnavailableText: string;
+  loansNotOverdueText: string;
+  patronContactInfoBodyText: string;
+  pauseReservationModalBelowInputsText: string;
+  materialDetailsCloseModalAriaLabelText: string;
+  findOnShelfExpandButtonExplanationText: string;
 }

src/core/storybook/materialDetailsModalArgs.ts

@@ -24,12 +24,6 @@ export default {
     },
     defaultValue: "Material Item Number"
   },
-  materialDetailsCloseModalAriaLabelText: {
-    control: {
-      type: "text"
-    },
-    defaultValue: "Close material details modal"
-  },
   materialDetailsLinkToPageWithFeesText: {
     control: {
       type: "text"
@@ -84,7 +78,6 @@ export interface MaterialDetailsModalProps {
   materialDetailsPhysicalDueDateLabelText: string;
   materialDetailsLoanDateLabelText: string;
   materialDetailsMaterialNumberLabelText: string;
-  materialDetailsCloseModalAriaLabelText: string;
   materialDetailsLinkToPageWithFeesText: string;
   materialDetailsOverdueText: string;
   feesPageUrl: string;