Delete text on user me loans #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dresse
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Good that you have removed it in dpl-react, but I also think it would be best to remove it from dpl-cms.
Also shouldn't it also be removed from the groupModalArgs.ts file?
https://github.com/danskernesdigitalebibliotek/dpl-react/blob/sprint/lsbp-12/src/core/storybook/groupModalArgs.ts
|
Jeez, thx for this! |
No worries! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-463
Description
Removes subheadline from loan list modal about where the loan can be returned.
Screenshot of the result
Additional comments or questions