Fix/availability blacklisting #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This key has changed in the specs for the FBI API a while back.
We were using this eslint-disable to only use a useEffect once - on load. We achieve the same by adding the function used inside the useEffect.
Because the app should expect it - like every other app, because it's a global config.
In the useGetHoldings & getBlacklistedQueryArgs helper functions. It is necessary for the Find on shelf modal to work properly.
In the find on shelf modal on the material page.
These should be taken into consideration when checking whether a material can be reserved from another library.
Dresse
approved these changes
Apr 4, 2024
Co-authored-by: Andreas Nielsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-493
Description
This PR makes changes to fetching availability data for works - for find on shelf modal, and the reserve button on material page for materials that can be loaned from another library (overbygningsmaterialer). We forgot to take the Drupal config blacklisted availability branches into account before.
Screenshot of the result
Additional comments or questions