Renewal reason should fit in #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDF agreed to shorten these to make them fit better.
danskernesdigitalebibliotek/dpl-design-system#567 Some of the DOM structure changed.
...and provide the SelectableMaterial component with a mobile version of a status badge.
spaceo
reviewed
Apr 9, 2024
spaceo
reviewed
Apr 10, 2024
src/apps/loan-list/materials/selectable-material/selectable-material.tsx
Outdated
Show resolved
Hide resolved
spaceo
reviewed
Apr 10, 2024
spaceo
requested changes
Apr 10, 2024
spaceo
reviewed
Apr 15, 2024
spaceo
reviewed
Apr 15, 2024
spaceo
requested changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-405
Description
This PR follows up on changes made in the design system and adjusts the component and HTML structure to reflect these changes.
The reasoning behind these changes is meant to ensure that if a loan can't be renewed, the reasoning message fits well in the item card without pushing content around.
Screenshot of the result
Additional comments or questions