Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text under login and favorites #1141

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Apr 22, 2024

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-551

Description

This PR adds "Login" text under the user icon when user isn't logged in, and "Liked" under the heart icon in the nav menu, introducing two new text strings in the process.

Screenshot of the result

Additional comments or questions

Sibling PR in the design system
Sibling PR in the cms

Copy link
Contributor

@Dresse Dresse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Adamik10 Adamik10 merged commit a468dab into release/brahma-15 Apr 23, 2024
20 checks passed
@Adamik10 Adamik10 deleted the add-text-under-login-and-favorites branch April 23, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants