Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored removeModalIdFromUrl to use common URL functions #1143

Merged
merged 1 commit into from
May 7, 2024

Conversation

clausbruun
Copy link
Contributor

@clausbruun clausbruun commented Apr 23, 2024

Description

Refactored removeModalIdFromUrl to use common URL functions for consistency. Also, see the Zulip thread here.

Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Base automatically changed from release/brahma-15 to develop May 2, 2024 13:40
@clausbruun clausbruun changed the base branch from develop to release/brahma-15-1 May 7, 2024 10:23
@clausbruun clausbruun merged commit 85972a4 into release/brahma-15-1 May 7, 2024
20 checks passed
@clausbruun clausbruun deleted the fix/use-common-url-functions branch May 7, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants