-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform about fees when loan is overdue #1145
Merged
Adamik10
merged 11 commits into
release/brahma-15-1
from
inform-about-fees-when-loan-is-overdue
May 3, 2024
Merged
Inform about fees when loan is overdue #1145
Adamik10
merged 11 commits into
release/brahma-15-1
from
inform-about-fees-when-loan-is-overdue
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Texts added: - feeListYouHaveOverdueLoansText - feeListSeeYourOverdueLoansText - feeListSeeYourOverdueLoansAriaText Url added: - physicalLoansUrl (as used in other components)
In some use cases we would like to adjust the margin between elements above and below.
To let the user know that they might get more fines than just those that are on the fees page currently.
In the fee list component
Otherwise it doesn't properly get interrupted.
spaceo
reviewed
Apr 24, 2024
spaceo
reviewed
Apr 24, 2024
spaceo
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Work @Adamik10 👏
I have some comments for you to consider
spaceo
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-553
Description
This PR adds a warning bar on top of the fees page is user has any overdue loans.
+ tests
Screenshot of the result
Additional comments or questions
Sibling PR