Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform about fees when loan is overdue #1145

Merged
merged 11 commits into from
May 3, 2024

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Apr 23, 2024

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-553

Description

This PR adds a warning bar on top of the fees page is user has any overdue loans.
+ tests

Screenshot of the result

Additional comments or questions

Sibling PR

Texts added:
- feeListYouHaveOverdueLoansText
- feeListSeeYourOverdueLoansText
- feeListSeeYourOverdueLoansAriaText

Url added:
- physicalLoansUrl (as used in other components)
In some use cases we would like to adjust the margin between elements
above and below.
To let the user know that they might get more fines than just those
that are on the fees page currently.
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @Adamik10 👏
I have some comments for you to consider

@Adamik10 Adamik10 changed the base branch from release/brahma-15 to release/brahma-15-1 April 26, 2024 10:42
@Adamik10 Adamik10 requested a review from spaceo April 26, 2024 13:46
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@spaceo spaceo removed their assignment May 1, 2024
@Adamik10 Adamik10 merged commit c3227a5 into release/brahma-15-1 May 3, 2024
20 checks passed
@Adamik10 Adamik10 deleted the inform-about-fees-when-loan-is-overdue branch May 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants