Ddfform 802 sort openning hours #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is not used anywhere and is the same as `dateTime`
LasseStaus
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Good catch with the date and the sorting.
It is definitely a nice addition with the sorting.
You could consider implementing another sorting, for the end_time if the start_time of two entries are the same.
so in this example :
The second "Åbent" would be before "Med betjening" since it ends sooner than "Åbent".
I think that would could be nice also to do if it doesn't take a lot of time. 🚀
Ensure that opening hours are sorted in the correct chronological order based on `start_time` and `end_time` when `start_time` is identical: - Åbent 06:00 - 22:00 - Åbent 10:00 - 15:00 - Åbent 10:00 - 17:00 - Åbent 12:00 - 13:00
kasperbirch1
force-pushed
the
DDFFORM-802-sort-openning-hours
branch
from
fad2e73 to
0324e47
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Jun 4, 2024
LasseStaus
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFFORM-802
Description
This pull request implements sorting for opening hours.
Ensure that opening hours are sorted in the correct chronological order based on
start_timeandend_timewhenstart_timeis identical:Additionally, I identified a redundant date value from
groupOpeningHoursByWeekdaythat was duplicated by thedateTimevalue.Test on:
http://varnish.pr-1211.dpl-cms.dplplat01.dpl.reload.dk/test-raekkefolge-af-abningstider
Screenshot of the result