Availability bug #1348
Merged
Availability bug #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceo
force-pushed
the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
3 times, most recently
from
0a363ab to
56ab856
Compare
spaceo
force-pushed
the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
from
56ab856 to
4b4fa49
Compare
Two major factors to be aware of here: * Three hooks are introduced instead of one: One main hook and one for physical and one for online materials, to get a better overview of the rules and the logic. * Apparently we cannot make use of `onSuccess` handlers on queries if the request have alredy been performed and the data is delivered the second time by the `QueryClient` cache. And that is the case of the availability labels on a material page, where they are used both in the header and in the "udagver" section later on the page.
spaceo
force-pushed
the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
from
4b4fa49 to
4280787
Compare
spaceo
force-pushed
the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
3 times, most recently
from
5d6484e to
56fc307
Compare
Adamik10
reviewed
Aug 2, 2024
There was a problem hiding this comment.
I have two comments that I think you should consider before moving on with this :)
Otherwise I can't see any more potential problems :) Fingers crossed that it all works as they intended, since DDF has soooo much business logic in regard to availability 🤯
Luckily, someone from DDF (probably Tue) will be reviewing this too.
src/components/availability-label/usePhysicalAvailabilityData.ts
Outdated
Show resolved
Hide resolved
spaceo
force-pushed
the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
6 times, most recently
from
b4c7275 to
f49c496
Compare
spaceo
force-pushed
the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
from
f49c496 to
9ed98b6
Compare
Since we have multiple article types we should consider those in the various places where we have functionality relying on those types.
spaceo
force-pushed
the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
from
9ed98b6 to
db378df
Compare
spaceo
deleted the
DDFLSBP-722-availability-labels-viser-udlant-under-udgaver-skont-bogen-er-hjemme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-722
Description
The main problem was that because the availability hook can be run twice with the same parameters eg on the material page where the availability labels are presented. The former version of
useAvailabilityDatacould not handle that scenario.physical and one for online materials, to get a better overview of
the rules and the logic.
onSuccesshandlers on queries ifthe request have alredy been performed and the data is delivered the
second time by the
QueryClientcache. And that is the case of theavailability labels on a material page, where they are used both in the
header and in the "udgaver" section later on the page.