DDFLSBP-621 - Make sure to only show blocked modal when logging in #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have decided to implement this differently. That is why I am closing this. |
spaceo
force-pushed
the
DDFLSBP-621-only-show-blocked-modal-when-reserving
branch
from
7cf7ea1 to
b9d07e3
Compare
Since the cms is handling those cases we do not need to take them into consideration
Otherwise we will get a missing text error when developing
spaceo
force-pushed
the
DDFLSBP-621-only-show-blocked-modal-when-reserving
branch
2 times, most recently
from
f50c504 to
6ea9924
Compare
The initial implementation was unclear and buggy. So we reduced the amount of states and cleaned up the code.
Make sure that it is remembered across page loads
This has been used in a previous version of the apps but are not in use anymore.
Make sure that the persisted redux states are cleared before logging out.
spaceo
force-pushed
the
DDFLSBP-621-only-show-blocked-modal-when-reserving
branch
from
6ea9924 to
89742de
Compare
Adamik10
approved these changes
Aug 19, 2024
| BlockedTypes.automatonBlocked, | ||
| BlockedTypes.extendedExclusion, | ||
| BlockedTypes.stolen | ||
| BlockedTypes.extendedSuspension |
There was a problem hiding this comment.
Why did you delete the previous lines?
There was a problem hiding this comment.
Because the cms is taking care of handling that type of blocked users
spaceo
approved these changes
Aug 19, 2024
Since the behaviour has changed we need to update the tests accordingly.
spaceo
force-pushed
the
DDFLSBP-621-only-show-blocked-modal-when-reserving
branch
from
32c8811 to
0fdcae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-621
Description
To avoid spamming the user with a popup modal informing the user that they have unpaid fees and are therefore "blocked" on all pages, we add a check to see if the user has just logged in or not.
This way we only show the modal once, and the user can then navigate freely afterwards.
If was suggested that the modal should also be shown whenever the user is trying to reserve a book, but as the button for reserving is "disabled" when a user is blocked, this is already taken care of.
Update 18 Aug
We decided to rewrite the blocked modal functionality because the code was unclear and difficult to maintain.
Furthermore we added that the persisted redux store is cleared upon logout, to make sure that data is not surviving between sessions. In that way other user will not be able to see previous users state. By clearing the persisted data upon logout we also make sure that the same user will be presented with the blocked modal again when logging out and in again.