Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Cypress #1501

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Upgrade Cypress #1501

merged 5 commits into from
Oct 29, 2024

Conversation

JacobArrow
Copy link
Contributor

@JacobArrow JacobArrow commented Oct 24, 2024 •
edited
Loading

Link to issue

https://reload.atlassian.net/browse/DDFBRA-136

Description

  • Bump Cypress to v13.15.0
  • Disable Test Isolation
  • use 'first()' on 'within()'
  • Import Cypress plugins

@JacobArrow JacobArrow force-pushed the DDFBRA-136-upgrade-cypress branch from d696c27 to df12225 Compare October 24, 2024 12:59
@JacobArrow
Upgrade Cypress to version 10
ec4f255 
IntegrationFolder is now deprecated and the config file should instead rely on Testing Type-Specific Options
https://docs.cypress.io/app/references/configuration#Testing-Type-Specific-Options
@JacobArrow
Upgraded Cypress to version 13
436d030
@JacobArrow
Disable Test Isolation
85d9012 
By default test isolation will be enabled in Cypress 12 and up, but out tests are not ready to run isolated yet. This should be prioritized in another task.
@JacobArrow
Use first() as within() can only be called on a single element
02f998d
@JacobArrow
Import cypress plugins
dacb795 
As Cypress 10 depricates the use of a native separate plugins file, we need to import it into the config
@JacobArrow JacobArrow force-pushed the DDFBRA-136-upgrade-cypress branch 2 times, most recently from 62ca0f5 to dacb795 Compare October 28, 2024 15:09
kasperbirch1
kasperbirch1 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@kasperbirch1 kasperbirch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 But I think @kasperg should also approve it

@kasperbirch1 kasperbirch1 removed their assignment Oct 29, 2024
kasperg
kasperg approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice. I appreciate the effort made in splitting the work into individual commits.

@kasperg kasperg assigned kasperbirch1 and unassigned kasperg Oct 29, 2024
@JacobArrow JacobArrow merged commit a30c009 into develop Oct 29, 2024
20 checks passed
@JacobArrow JacobArrow deleted the DDFBRA-136-upgrade-cypress branch October 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperbirch1 kasperbirch1 kasperbirch1 approved these changes

@kasperg kasperg kasperg approved these changes

Assignees

@kasperbirch1 kasperbirch1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobArrow @kasperg @kasperbirch1