Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Typescript to newest version #1538

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

JacobArrow
Copy link
Contributor

@JacobArrow JacobArrow commented Nov 11, 2024

Link to issue

https://reload.atlassian.net/browse/DDFBRA-181

Description

  • Upgrade Typescript to version 5.6.3
  • Cleanup Cypress commands
  • Fix type errors caused by Typescript upgrade

@JacobArrow JacobArrow marked this pull request as draft November 11, 2024 13:42
The `cy.get` command in Cypress does not accept additional arguments after the selector string.
@JacobArrow JacobArrow marked this pull request as ready for review November 11, 2024 15:14
@JacobArrow JacobArrow changed the title Upgrade Typescript Upgrade Typescript to newest version Nov 11, 2024
Copy link
Contributor

@kasperbirch1 kasperbirch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/core/utils/withSuffix.tsx Show resolved Hide resolved
@JacobArrow JacobArrow merged commit ef3a44d into develop Nov 12, 2024
20 checks passed
@JacobArrow JacobArrow deleted the DDFBRA-181-upgrade-typescript branch November 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants