-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDFBRA-184 - Anonymous and logged in user can try audiobook #1562
Merged
kasperbirch1
merged 6 commits into
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
from
DDFBRA-184-anonymous-and-logged-in-user-can-try-audiobook
Nov 26, 2024
Merged
DDFBRA-184 - Anonymous and logged in user can try audiobook #1562
kasperbirch1
merged 6 commits into
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
from
DDFBRA-184-anonymous-and-logged-in-user-can-try-audiobook
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the `Player` component, which functions similarly to the `Reader`. Considering moving the `Reader` component to the `components` folder for consistency in folder structure.
This enables the player teaser button for the correct material types: "lydbog (online)", "podcast", "musik (online)", "lydbog (bånd)" that opens in a modal `PlayerModal`.
These components are very similar and distinct from other components, so I have moved them together into the same folder and created a new story category called "ReaderPlayer" for them.
These will, in the future, not only be used for showing teasers.
The function now accepts a `@materialType`, which can also reference translatable strings such as `ebookText` or `audiobookText`.
This is now handled in `.player` CSS.
kasperbirch1
force-pushed
the
DDFBRA-184-anonymous-and-logged-in-user-can-try-audiobook
branch
from
November 26, 2024 12:47
a6c0d19
to
f2bf874
Compare
kasperbirch1
changed the base branch from
develop
to
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
November 26, 2024 12:50
kasperbirch1
changed the title
WIP: DDFBRA-184 - Anonymous and logged in user can try audiobook
DDFBRA-184 - Anonymous and logged in user can try audiobook
Nov 26, 2024
kasperbirch1
merged commit Nov 26, 2024
3529f06
into
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
20 checks passed
kasperbirch1
deleted the
DDFBRA-184-anonymous-and-logged-in-user-can-try-audiobook
branch
November 26, 2024 12:56
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 26, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 26, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 26, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 26, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 27, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 3, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 3, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 6, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 12, 2024
These translations are related to the implementation of the `Player` feature in PR: danskernesdigitalebibliotek/dpl-react#1562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-184
Description
This pull request adds the
Player
teaser feature. It continues the work started in PR #1555 and will be merged into that PR.Since the
Player
andReader
functionalities share significant overlap in the codebase, this PR also includes some restructuring of code introduced in the earlier PR.Depend on:
#1555