Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFBRA-229 - Test favorites #1564

Merged
merged 3 commits into from
Dec 13, 2024
Merged

DDFBRA-229 - Test favorites #1564

merged 3 commits into from
Dec 13, 2024

Conversation

JacobArrow
Copy link
Contributor

@JacobArrow JacobArrow commented Nov 27, 2024

Link to issue

https://reload.atlassian.net/browse/DDFBRA-229

Description

While working with upgrades within the project, I discovered that we don't actually test the functionality of favorites.
This PR extends favorites-list.test.ts and material.test.ts to also test the functionality of favorites.

@JacobArrow JacobArrow force-pushed the DDFBRA-229-test-favorites branch from cde2af9 to 46a2ea8 Compare November 28, 2024 14:09
@JacobArrow JacobArrow changed the title DDFBRA-229-test-favorites Test favorites Nov 28, 2024
@JacobArrow JacobArrow marked this pull request as ready for review November 28, 2024 14:13
@JacobArrow JacobArrow changed the title Test favorites DDFBRA-229 - Test favorites Dec 9, 2024
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I likey. Good job!
I just have a comment in regards to structuring that I think should be addressed before we merge this in 😉

src/apps/favorites-list/favorites-list.test.ts Outdated Show resolved Hide resolved
src/apps/material/material.test.ts Show resolved Hide resolved
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Adamik10 Adamik10 removed their assignment Dec 13, 2024
@JacobArrow JacobArrow merged commit 5d4ff02 into develop Dec 13, 2024
20 checks passed
@JacobArrow JacobArrow deleted the DDFBRA-229-test-favorites branch December 13, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants