DDFBRA-236 - Logged in user can go from digital loans to material #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFBRA-236-logged-in-user-can-go-from-digital-loans-to-material-to-listen-read
branch
2 times, most recently
from
7a2cc4d to
a23e109
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 2, 2024
The translation key 'material-details-go-to-ereolen' has been updated to 'material-details-go-to-material' following changes made in: danskernesdigitalebibliotek/dpl-react#1565. Additionally, the 'ereolen-my-page-url' has been removed, as it no longer links to eReolen from the loans page.
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 3, 2024
The translation key 'material-details-go-to-ereolen' has been updated to 'material-details-go-to-material' following changes made in: danskernesdigitalebibliotek/dpl-react#1565. Additionally, the 'ereolen-my-page-url' has been removed, as it no longer links to eReolen from the loans page.
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
665996b to
e8a38e8
Compare
kasperbirch1
force-pushed
the
DDFBRA-236-logged-in-user-can-go-from-digital-loans-to-material-to-listen-read
branch
from
a23e109 to
a25ae80
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 3, 2024
The translation key 'material-details-go-to-ereolen' has been updated to 'material-details-go-to-material' following changes made in: danskernesdigitalebibliotek/dpl-react#1565. Additionally, the 'ereolen-my-page-url' has been removed, as it no longer links to eReolen from the loans page.
Adamik10
approved these changes
Dec 4, 2024
| @@ -33,6 +34,7 @@ const MaterialDetailsModal: FC<MaterialDetailsModalProps> = ({ | |||
| children | |||
| }) => { | |||
| const t = useText(); | |||
| // console.log("Rendering MaterialDetailsModal:"); | |||
There was a problem hiding this comment.
Maybe we should remove this line?
| @@ -1,3 +1,4 @@ | |||
| // Todo: Fix infinite loop in MaterialDetailsModal | |||
There was a problem hiding this comment.
Bahahaha. How fun.
Try to describe it better what needs to be fixed so that people who don't know about the bug at all would be able to reproduce it 😉
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 6, 2024
The translation key 'material-details-go-to-ereolen' has been updated to 'material-details-go-to-material' following changes made in: danskernesdigitalebibliotek/dpl-react#1565. Additionally, the 'ereolen-my-page-url' has been removed, as it no longer links to eReolen from the loans page.
kasperbirch1
force-pushed
the
DDFBRA-236-logged-in-user-can-go-from-digital-loans-to-material-to-listen-read
branch
from
a25ae80 to
c02d269
Compare
While investigating https://reload.atlassian.net/browse/DDFBRA-236, I identified an infinite loop in `MaterialDetailsModal`. This issue appears when the modal is opened via "user/loans" and potentially all places it is used
Since all data from loans comes from Publizon, we don’t have a `workId`, which is required to link to the material. Therefore, I use the `useComplexSearchWithPaginationQuery` to find the work using the ISBN (identifier) and construct the `workId` into a URL, e.g., `/work/work-of:870970-basis:62986115`. Additionally, if it finds the material type, it adds that as a parameter.
kasperbirch1
force-pushed
the
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
branch
from
d01a598 to
bd60ac0
Compare
kasperbirch1
force-pushed
the
DDFBRA-236-logged-in-user-can-go-from-digital-loans-to-material-to-listen-read
branch
from
c02d269 to
94c6cd2
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 12, 2024
The translation key 'material-details-go-to-ereolen' has been updated to 'material-details-go-to-material' following changes made in: danskernesdigitalebibliotek/dpl-react#1565. Additionally, the 'ereolen-my-page-url' has been removed, as it no longer links to eReolen from the loans page.
Base automatically changed from
DDFBRA-183-anonymous-and-logged-in-user-can-try-ebook
to
reader-player-feature
December 13, 2024 10:48
kasperbirch1
deleted the
DDFBRA-236-logged-in-user-can-go-from-digital-loans-to-material-to-listen-read
branch
kasperbirch1
added a commit
that referenced
this pull request
Dec 17, 2024
…logged-in-user-can-go-from-digital-loans-to-material-to-listen-read DDFBRA-236 - Logged in user can go from digital loans to material
kasperbirch1
added a commit
that referenced
this pull request
Jan 7, 2025
…logged-in-user-can-go-from-digital-loans-to-material-to-listen-read DDFBRA-236 - Logged in user can go from digital loans to material
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-236
danskernesdigitalebibliotek/dpl-cms#1814
Description
This pull request replaces the link from the digital loan list to point to the material page instead of eReolen.
Unfortunately, I also found a bug in our code that causes an infinite re-render. This issue is also present on the develop branch, and I didn't find an easy solution to fix it. Therefore, this should be fixed in a separate ticket.
Test
If you have an online loan, you can view it under the “Digital Loans” section. The button, which was previously labeled “Go to eReolen” and linked to eReolen, has been updated to now correctly link to the work with the appropriate type selected.
https://varnish.pr-1814.dpl-cms.dplplat01.dpl.reload.dk/user/me/loans
Min.film.1.mp4