Bump stylelint-prettier & prettier to latest non-breaking version possible #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both packages, cuz one is dependent on the other
Adamik10
changed the title
…ress plugins so the ones we use for linting are last (prettier adjecent)
Adamik10
force-pushed
the
DDFBRA-301-opgrader-stylelint-prettier-react-komponenter
branch
4 times, most recently
from
86182cf to
1a40807
Compare
Adamik10
changed the title
These are fixes to some of the latest breaking changes in the package.
… before package upgrade
ThomasGross
requested changes
Jan 6, 2025
kasperg
assigned Adamik10 and unassigned Dresse, rasben, JacobArrow, ThomasGross and kasperbirch1
kasperg
reviewed
Jan 7, 2025
| @@ -13,7 +13,7 @@ import AdvancedSearchEntry from "./AdvancedSearch.entry"; | |||
| const meta: Meta<typeof AdvancedSearchEntry> = { | |||
| title: "Apps / Advanced Search", | |||
| component: AdvancedSearchEntry, | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
|
|
|||
There was a problem hiding this comment.
Is this whitespace intentional?
This PR adds empty lines in the middle of many different files, in the middle of objects etc. It looks odd to me.
src/apps/loan-list/materials/selectable-material/selectable-material.tsx
Show resolved
Hide resolved
The plugin was added in the eslint.config.js but the ruleset wasn't added, which in this new eslint setup needs to be done explicitly.
…adjust prettier parser settings Read more at https://github.com/prettier/eslint-plugin-prettier#options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-301
https://reload.atlassian.net/browse/DDFBRA-302
https://reload.atlassian.net/browse/DDFBRA-307
https://reload.atlassian.net/browse/DDFNEXT-225
https://reload.atlassian.net/browse/DDFNEXT-397
https://reload.atlassian.net/browse/DDFNEXT-224
https://reload.atlassian.net/browse/DDFNEXT-222
Description
These packages were all intertwined, so it became one big thing. Good luck reviewing 🤞 😇
Screenshot of the result
Additional comments or questions