Don't allow double clicking on logout button #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a part of the movement to not use links ( <a/> ) when we need to do more than just simply redirect. Due to us sometimes (this case included) needing to do two separate things before redirecting, we in the past had to hack our way to the <a/> tag not firing the redirect, cuz we needed to first track the click + delete some persisted data.
This is a part of the movement to not use links ( <a/> ) when we need to do more than just simply redirect. Due to us sometimes (this case included) needing to do two separate things before redirecting, we in the past had to hack our way to the <a/> tag not firing the redirect, cuz we needed to first track the click + delete some persisted data.
Because we no longer use links when we need to track clicks (see prev. commits to understand why if that's what you're after).
Because we no longer use them in these scenarios. (Check previous commits to learn more.)
ThomasGross
reviewed
Jan 30, 2025
ThomasGross
approved these changes
Jan 30, 2025
Adamik10
deleted the
DDFBRA-331-log-ud-giver-meddelelse-beklager-du-har-ikke-adgang-til-denne-side-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-331
Description
This PR changes the way we use links ( ) when we need to do more than just simply redirect. The change was necessary when fixing a bug where users could click on the logout button multiple times, causing problems with mismatched tokens.
Due to us sometimes needing to do two separate things before redirecting, we in the past had to hack our way to the tag not firing the redirect, cuz we needed to first track the click + delete some persisted data.
I also fixed a small console error where mapped list items didn't have the "key" prop.
Screenshot of the result
Additional comments or questions