DDFBRA-231 - Add MaterialGridLinkAutomatic app
#1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is largely based on `MaterialGridAutomatic`, which is planned for deprecation. The update is required to support the `location` and `sublocation` parameters in `useComplexSearchWithPaginationQuery`. These parameters are extracted from the `link` field of the new `material_grid_link_automatic` paragraph type in `dpl-cms`.
kasperbirch1
force-pushed
the
DDFBRA-231-paragraph-material-grid-link-automatic
branch
from
02b9af7 to
06af065
Compare
spaceo
approved these changes
Feb 5, 2025
| export interface MaterialGridLinkAutomaticEntryProps | ||
| extends GlobalEntryTextProps, | ||
| MaterialGridLinkAutomaticEntryConfigProps { | ||
| link: string; |
There was a problem hiding this comment.
If you use the url siffix on this prop you dont have to cast it to an url (via new URL) later on
Standardizes the `link` prop by ensuring it is always cast to a `URL` object at the point of assignment. By enforcing a consistent type, we prevent potential issues arising from mixed string and URL usage throughout the application.
kasperbirch1
deleted the
DDFBRA-231-paragraph-material-grid-link-automatic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-231
Description
This pull request introduces the
MaterialGridLinkAutomaticapp, which is largely based onMaterialGridAutomatic. TheMaterialGridAutomaticwill be deprecated in the feature.This update integrating support for
locationandsublocationparameters inuseComplexSearchWithPaginationQuery. These parameters are now extracted from thelinkfield within the newly introducedmaterial_grid_link_automaticparagraph type indpl-cms.Test
https://varnish.pr-2026.dpl-cms.dplplat01.dpl.reload.dk/paragraph-side