DDFBRA-475 - Ensure that materials ready for loan display the correct "Lån før XX-XX-XXXX" date

[kasperbirch1]

Link to issue

https://reload.atlassian.net/browse/DDFBRA-475

Description

This pull request ensures that E-materials that have been "reserved" and are now "ready for loan" display the correct label.

Please see the commit description for details on the problem and its solution.

Test

https://varnish.pr-2139.dpl-cms.dplplat01.dpl.reload.dk/
danskernesdigitalebibliotek/dpl-cms#2139

Note:

This state for the material is rare and difficult to reproduce, so I faked it like this inside:

src/core/utils/useReservations.tsx

  const mappedReservationsPublizon = reservationsPublizon?.reservations
    ? mapPublizonReservationToReservationType([
        ...reservationsPublizon.reservations,
        // fake a publizon ready to loan material
        ...[
          {
            // productId: "lige meget",
            // productTitle: "Kasper tester",
            identifier: "9788740092912",
            status: 2,

            createdDateUtc: new Date(
              new Date().setDate(new Date().getDate() - 5)
            ).toISOString(),

            expectedRedeemDateUtc: new Date().toISOString(),

            expireDateUtc: new Date(
              new Date().setDate(new Date().getDate() + 2)
            ).toISOString()
          }
        ]
      ])
    : [];

[spaceo]

I think we have tests for this. If there are no test for this case I think we should make one.

PR Overview

This pull request addresses the issue of ensuring that E-materials ready for loan display the correct "Borrow before" date by updating both the presentation and test verification for digital reservations.

• Updated tests in the reservation list to verify the correct label for E-book reservations.
• Refactored the reservation material component to use the external digital product identifier instead of a separate identifier prop.

Reviewed Changes

File	Description
src/apps/reservation-list/list/reservation-list.test.ts	Added a test verifying that the E-book reservation is labeled correctly.
src/apps/reservation-list/reservation-material/reservation-material.tsx	Replaced usage of the "identifier" prop with "material?.externalProductId" to correctly determine digital reservations.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/apps/reservation-list/reservation-material/reservation-material.tsx:28

• [nitpick] Confirm that the shift from using 'identifier' to 'material.externalProductId' is consistent across the component and its usage. Ensure that corresponding prop types and any dependent logic are updated accordingly.

const isDigital = !!material?.externalProductId;

src/apps/reservation-list/list/reservation-list.test.ts:510

• [nitpick] Consider adding additional tests for varying date values to confirm that reservation labels dynamically display the correct 'Borrow before' date under different scenarios.

"Borrow before 27-01-2023 20:37"

[spaceo]

LGTM 👍