DDFBRA-187 - Remove eReolen references from the application
#1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up unused text and URLs that referred to `eReolen`. Additionally: - Removed `patronPageStatusSectionLinkText` and `alwaysAvailableEreolenUrl` as the concept no longer exists, since we can no longer search exclusively for blue titles.
There was a problem hiding this comment.
PR Overview
This PR removes all obsolete references to "eReolen" from the application, updating both user‐facing text and internal property names to reflect the current functionality. Key changes include:
- Removal of eReolen-related URL properties and texts from component props and Storybook configurations.
- Updating test assertions and comments to reflect the new naming conventions.
- Renaming variables and error messages to reference "Publizon" where appropriate.
Reviewed Changes
| File | Description |
|---|---|
| src/apps/reservation-list/list/reservation-list.entry.tsx | Removed the ereolenMyPageUrl property from ReservationListUrlProps. |
| src/apps/menu/menu.stories.tsx | Removed the ereolenHomepageUrl control and URL from story configuration. |
| src/core/utils/types/global-url-props.ts | Removed obsolete eReolen URL properties. |
| src/apps/reservation-list/modal/reservation-details/reservation-details.test.ts | Updated a comment from “go to ereolen” to “View material”. |
| src/apps/patron-page/PatronPage.stories.tsx | Removed eReolen URL properties and outdated link-related texts. |
| src/apps/patron-page/PatronPage.test.tsx | Updated assertions to reflect the removal of “eReolen” from header texts. |
| src/core/storybook/reservationMaterialDetailsArgs.ts | Removed the reservationDetailsDigitalReservationGoToEreolenText property. |
| src/apps/patron-page/PatronPage.entry.tsx | Removed eReolen-related properties from configuration interfaces. |
| src/core/storybook/reservationListArgs.ts | Removed the ereolenMyPageUrl property and its default value. |
| src/apps/reservation-list/list/reservation-list.stories.tsx | Removed eReolen URL properties from story defaults. |
| src/components/availability-label/useOnlineAvailabilityData.ts | Updated comments and variable names from Ereol to Publizon, but a condition still references “Ereol”. |
| src/apps/patron-page/sections/StatusSection.tsx | Removed the link to the obsolete alwaysAvailableEreolenUrl. |
| src/core/storybook/publizonErrorArgs.ts | Updated error message to replace “eReolen” with “publizon”. |
| src/components/material/reserve-button.md | Updated button text from “Gå til ereolen” to “Gå til materialet”. |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/components/availability-label/useOnlineAvailabilityData.ts:49
- The condition still checks for "Ereol" even though the surrounding comments and naming have been updated to "Publizon". Consider updating this condition to ensure consistency.
access.some((acc) => acc === "Ereol")
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Mar 6, 2025
This reflects the changes required for [PR #1730](danskernesdigitalebibliotek/dpl-react#1730). Includes an update hook that removes unused data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-187
Description
This PR removes obsolete references to
eReolenin the application.eReolen.patronPageStatusSectionLinkTextandalwaysAvailableEreolenUrlas these concepts are no longer relevant since we can not filter exclusively for blue titles.DPL-CMS PR:
danskernesdigitalebibliotek/dpl-cms#2144
Test
https://varnish.pr-2144.dpl-cms.dplplat01.dpl.reload.dk/