Introduce OpenOrder Logic and Components for 'Overbygningmaterialer' #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFSOEG-529-udvid-bestillingsknapper-med-bestil-pa-andet-bibliotek-s-knap
branch
from
03db65c to
c9764b3
Compare
kasperbirch1
force-pushed
the
DDFSOEG-529-udvid-bestillingsknapper-med-bestil-pa-andet-bibliotek-s-knap
branch
from
a4c3d2b to
7c23601
Compare
kasperbirch1
force-pushed
the
DDFSOEG-529-udvid-bestillingsknapper-med-bestil-pa-andet-bibliotek-s-knap
branch
2 times, most recently
from
05c5f02 to
e19a754
Compare
kasperbirch1
force-pushed
the
DDFSOEG-529-udvid-bestillingsknapper-med-bestil-pa-andet-bibliotek-s-knap
branch
from
e19a754 to
0feb17f
Compare
kasperbirch1
changed the title
MaterialButtonReservableOnAnotherLibrary button
spaceo
requested changes
Oct 2, 2023
src/components/material/material-buttons/physical/MaterialButtonReservableOnAnotherLibrary.tsx
Outdated
Show resolved
Hide resolved
src/components/material/material-buttons/physical/MaterialButtonReservableOnAnotherLibrary.tsx
Outdated
Show resolved
Hide resolved
src/components/material/material-buttons/physical/MaterialButtonReservableOnAnotherLibrary.tsx
Outdated
Show resolved
Hide resolved
This is needed to determine if the manifestation can be reserved at another library (overbygningsmaterialer).
This is used to handle overbygningsmaterialer (openOrder)
- Implemented a new function `getReservableOnAnotherLibrary` to verify if a material is categorized as "overbygningsmateriale". This function returns both a boolean and a list of PIDs. - Utilized `getReservableOnAnotherLibrary` function to determine the visibility of the `MaterialButtonReservableOnAnotherLibrary` button. - Introduced a new component, `OpenOrderResponse`, as the `ReservationSuccess` does not have the same response structure. - Added `translateOpenOrderStatus` to interpret and display the response status.
After adding catalogueCodes, the mocked data/fixtures were no longer up-to-date.
To unify modal response handling
…PidsFromAnotherLibrary` Previously, we returned both 'isReservable' and a list of 'pids'. Now, we only return the list of pids and check its length to determine, for example, if the button should change its name.
Replacing the switch-case statement with a mapping object
kasperbirch1
force-pushed
the
DDFSOEG-529-udvid-bestillingsknapper-med-bestil-pa-andet-bibliotek-s-knap
branch
from
2579cd0 to
11bd97a
Compare
Prevent the use of magic number for open order interest days.
kasperg
deleted the
DDFSOEG-529-udvid-bestillingsknapper-med-bestil-pa-andet-bibliotek-s-knap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFSOEG-528
Description
This PR introduces the logic and components for ordering a book from 'overbygningmaterialer' (openOrder).
To determine that the material is available as an 'overbygningmateriale', I have made a function called
getReservableOnAnotherLibrary. This function returns a boolean and a list of PIDS that start with 'OVE' in otherCatalogues.I have created a new graphql mutation called
openOrderthat is called instead of the normal reservation inside theReservationModalBody.Because the response is so different from the normal reservation, I have made a separate component called
OpenOrderResponsethat handles the messages that are returned.I have added a unit test for the
getReservableOnAnotherLibraryand a cypress e2e test that shows different messages depending on the response.Screenshot of the result
Checklist
Additional comments or questions