Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced node-sass with sass #578

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

JacobArrow
Copy link
Contributor

@JacobArrow JacobArrow commented Oct 6, 2023

Description

As it turned out the node-sass version we were using, was causing trouble when compiling on Windows, we decided to replace it with sass instead.

To keep the integration with postcss we are using a postcss-sass package to compile scss correctly

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

@JacobArrow JacobArrow requested a review from kasperg October 6, 2023 12:27
Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Consider squashing your extra commit before merging.

As it turned out the node-sass version we were using, was causing trouble when compiling on Windows, we decided to replace it with sass instead.

To keep the integration with postcss we are using a postcss-sass package to compile scss correctly
@JacobArrow JacobArrow force-pushed the replace-node-sass-with-sass branch from fae2d55 to c0dccdd Compare October 12, 2023 09:11
@JacobArrow JacobArrow merged commit d7e9641 into develop Oct 12, 2023
16 checks passed
@JacobArrow JacobArrow deleted the replace-node-sass-with-sass branch October 12, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants