Make register/create patron form show and make email field optional #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceo
force-pushed
the
DDFLSBP-121-brugeroprettelse-formular-vises-ikke-i-forbindelse-med-oprettelse
branch
2 times, most recently
from
a1c8a40 to
08a7d58
Compare
spaceo
changed the title
spaceo
force-pushed
the
DDFLSBP-121-brugeroprettelse-formular-vises-ikke-i-forbindelse-med-oprettelse
branch
2 times, most recently
from
15728c3 to
75e5c84
Compare
kasperbirch1
approved these changes
Oct 10, 2023
kasperg
approved these changes
Oct 10, 2023
Comment on lines
58
to
62
| <h2>Please Log ind..</h2> | ||
| <p> | ||
| When the flash message/info bar has been implemented, we will use it | ||
| here to tell the user to log in. | ||
| </p> |
There was a problem hiding this comment.
Consider moving this to a // TODO comment.
Personally I appreciate the effort but am not too keen on this ending up in code that will reach the end user - even during testing.
There was a problem hiding this comment.
Actually at the latest meeting we talked about returning 403 in this case. So I will remove the whole thing in return of a comment about that agreement.
In order to reflect what the purpose of the url actually is. Also use useEffect which is recommended best practise when fetching data in React components.
If the user token is not set the user should be asked to log in.
And add a test for wrapping the contact info depending on that the input fields should be shown inline or not.
We should get the token in the apps in a unified manner not passing it as a prop to the app
in contact info. Just to make things more clear.´
Maybe I am wrong but things seemed of and messed around. This is my attempt to make things look more sensible.
I accidentally swapped the logic. It should be EMAIL that is required. NOT PHONE.
The hosting application/site should handle this situation
spaceo
force-pushed
the
DDFLSBP-121-brugeroprettelse-formular-vises-ikke-i-forbindelse-med-oprettelse
branch
from
920a9a3 to
7a9a2bc
Compare
spaceo
merged commit f87dd9c
into
danskernesdigitalebibliotek:develop
9 of 10 checks passed
kasperg
deleted the
DDFLSBP-121-brugeroprettelse-formular-vises-ikke-i-forbindelse-med-oprettelse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reflect what the purpose of the url actually is. Also use useEffect which is recommended best practise when fetching data in React components.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-121
Description
Rename loginUrl to userinfoUrl in order to reflect what the purpose of the url actually is. Also use useEffect which is recommended best practise when fetching data in React components.
Additional comments
We should have a talk with DDF how the user experience is in the user creation/update flows for logged in and anonymous users.