Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timezone for Cypress in GitHub Action #587

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented Oct 10, 2023

Link to issue

Please add a link to the issue being addressed by this change.

Description

Align local tests with the timezone used in GitHub Actions to ensure consistency.

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My complies with our coding guidelines.
  • My code passes our static analysis suite. If not then I have added a comment explaining why this change should be exempt from the code standards and process.
  • My code passes our continuous integration process. If not then I have added a comment explaining why this change should be exempt from the code standards and process.

Additional comments or questions

If you have any further comments or questions for the reviewer them please add them here.

@kasperbirch1 kasperbirch1 force-pushed the change-timezone-on-github branch from 459593e to a39a559 Compare October 10, 2023 11:34
Align local tests with the timezone used in GitHub Actions to ensure consistency.
Adjust the time in the `reservation-details` Cypress test due to the introduction of the Danish timezone in our GitHub Actions environment.
@kasperbirch1 kasperbirch1 force-pushed the change-timezone-on-github branch from a39a559 to d8eb820 Compare October 10, 2023 11:45
@spaceo spaceo self-requested a review October 10, 2023 12:29
@spaceo spaceo removed their assignment Oct 10, 2023
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kasperbirch1 kasperbirch1 merged commit 8fe5280 into danskernesdigitalebibliotek:develop Oct 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants