Fix/card clicks #603
Merged
Fix/card clicks #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamik10
assigned kasperg, kasperbirch1, spaceo and JacobArrow and unassigned kasperg, spaceo, JacobArrow and kasperbirch1
Adamik10
force-pushed
the
fix/card-clicks
branch
from
15d910e to
1899124
Compare
Adamik10
changed the title
Before, the user would have to click on the card title, or an arrow that shows up on hover.
So the problem was that "stackable material" and "reservation material" are cards that need to be clickable, but they also have elements inside that need to be clickable, sometimes with different effects. We now make sure that the children elements handle the click events and don't trigger the parent card onClick event handler.
Adamik10
force-pushed
the
fix/card-clicks
branch
from
4dcdbe0 to
b38ef30
Compare
Adamik10
merged commit c649789
into
danskernesdigitalebibliotek:develop
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-168
Description
Makes reservation material & stackable material card clickable. Before, the user would have to click on the card title, or an arrow that shows up on hover.
Screenshot of the result
n/a
Checklist
Additional comments or questions
n/a