Fix/scroll behind modals #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Adamik10
changed the title
Adamik10
assigned kasperg, spaceo, JacobArrow and kasperbirch1 and unassigned kasperg, spaceo, JacobArrow and kasperbirch1
Before, the header was obstructing modals on mobile, and it wasn't possible to close them.
Adamik10
merged commit 2a05867
into
danskernesdigitalebibliotek:develop
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-81
Description
This PR disables scrolling on the body element as long as any modals are open.
We also make sure that modals' z-index is higher than header's so that modals don't get obstructed.
Screenshot of the result
n/a
Checklist
Additional comments or questions
n/a