DDFLSBP 161 digitale reserveringer klar til dig klokkeslaet og korrekt dato skal vises #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/apps/loan-list/materials/selectable-material/selectable-material.tsx
Show resolved
Hide resolved
Make sure that timestamp is present besides the date. Try to do it in a more unified manner.
Apperently that is the correct date compared to dueDate on loans of other material types.
By renaming the parameters and thereby make the purpose of the functions and their parameters self explanatory. Hopefully it is more clear :)
By making a component dedicted for that use: ReservationStatusInfoLabelDigital
Including the latest getReservationStatusInfoLabel.
Since this former PR: danskernesdigitalebibliotek#602 was conflicting with this and creating double digital information labels in groupmodals the ReservationStatusInfoLabelDigital component had to go
spaceo
force-pushed
the
DDFLSBP-161-digitale-reserveringer-klar-til-dig-klokkeslaet-og-korrekt-dato-skal-vises
branch
from
852870d to
0703487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-161
Description
Additional comments
This should be merged first and will probably cause conflicts with this PR.