Set the patron preferredPickupBranch instead of the empty string in openOrder
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `openOrder` The previous implementation set an empty string for the `pickUpBranch` field in `openOrder` if `selectedBranch` was not provided. However, an empty string is still considered a valid value when sent to the API, which triggered an `UNKNOWN_USER` error due to the user not being found. Additionally, the `getPatronAddress` function has been removed as it's no longer necessary to send the address. There was a concern regarding potential mismatches in address formatting, which could result in errors since `openOrder` requires exact matches for input values.
kasperbirch1
force-pushed
the
fix-openOrder
branch
from
9b4b7cb to
2a061b7
Compare
kasperbirch1
merged commit 3becebd
into
danskernesdigitalebibliotek:develop
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFSOEG-528
Description
The previous implementation set an empty string for the
pickUpBranchfield inopenOrderifselectedBranchwas not provided. However, an empty string is still considered a valid value when sent to the API, which triggered aUNKNOWN_USERerror due to the user not being found.Additionally, the
getPatronAddressfunction has been removed as it's no longer necessary to send the address. There was a concern regarding potential mismatches in address formatting, which could result in errors sinceopenOrderrequires exact matches for input values.