Add id to the checkbox and wrap the icon and label text with a labe…
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l using `htmlFor` to toggle the checkbox when clicking on the box/icon and label text.
JacobArrow
reviewed
Nov 9, 2023
kasperbirch1
merged commit bb6b623
into
danskernesdigitalebibliotek:develop
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFSOEG-584
Description
This Pull Request addresses a bug where toggling the checkbox by clicking the associated label or the custom-styled checkbox icon was not functioning as intended.
The issue was introduced in a recent commit 3ab8f4f which affected the checkbox's
idassociation with the label'shtmlForproperty, thereby breaking the expected toggle behavior.I have also improved the dashboard tests to confirm working checkboxes
Screenshot of the result
Skaermoptagelse.2023-11-09.kl.15.31.35.mov