Refactor reservation pause banner #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was not clear if a pause was active or not, and a toggle button was used to open a modal for changing settings.
This test is not testing pausing of reservations, so the fixture does not need to have any onHold information
kasperbirch1
approved these changes
Nov 17, 2023
JacobArrow
merged commit 61eb286
into
danskernesdigitalebibliotek:develop
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-70
Description
Previously it was not clear if a pause was active or not, and a toggle button was used to open a modal for changing settings.
This PR adds some descriptive text about the state of the current pause and a "Settings" button that behaves as expected.
Screenshot of the result