Show "online access" label for all digital materials #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobArrow
reviewed
Nov 15, 2023
Comment on lines
84
to
88
| label={ | ||
| !isDigital | ||
| ? [pickupLibrary, pickupNumber || ""] | ||
| : [t("reservationListDigitalPickupText")] | ||
| } |
There was a problem hiding this comment.
I guess my speculations here turned out to be true 😅
JacobArrow
reviewed
Nov 15, 2023
src/apps/reservation-list/reservation-material/reservation-info.tsx
Outdated
Show resolved
Hide resolved
JacobArrow
approved these changes
Nov 15, 2023
So instead of checking whether a material isn't digital (!isDigital) we check whether it is. Because it makes more logical sense.
Adamik10
merged commit aa29c1d
into
danskernesdigitalebibliotek:develop
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-213
Description
This PR introduces a fix so that all digital reservations get the correct label, instead of the physical reservation address.
Screenshot of the result
n/a
Additional comments or questions
n/a