Esbuild loader #683
Closed
Esbuild loader #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This js file uses JSX syntax. We have to treat it separately. Including loader: jsx in the existing loader makes it not work with TypeScript so split in into two different loaders for JSX/TS/TSX and JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be nice if building was faster. I tried to see what we could do by leveraging esbuild
instead of Babel and TypeScript.
You can test the difference by running
yarn run build:js:prodwith and without this change. It would also be nice if it made a difference with our Storybook setup.Additional comments or questions
If we want to go for this we can drop babel and the related dependencies.