Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable body scrolling after closing the last modal, not after every #687

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Nov 17, 2023

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-283

Description

This PR fixes an issue with scrolling behind modals. The user shouldn't be able to scroll in the content behind a modal until the very last modal is closed. Before, the scrolling was made possible after any modal was closed.

Screenshot of the result

n/a

Additional comments or questions

n/a

Copy link
Contributor

@kasperbirch1 kasperbirch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Adamik10 Adamik10 merged commit 8cf704d into danskernesdigitalebibliotek:develop Nov 17, 2023
8 checks passed
@Adamik10 Adamik10 deleted the fix/scrolling-behind-modals branch November 17, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants