Fix/stacked card click #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamik10
requested review from
kasperg,
spaceo,
JacobArrow and
kasperbirch1
and removed request for
kasperg,
spaceo,
JacobArrow and
kasperbirch1
JacobArrow
reviewed
Nov 17, 2023
src/apps/loan-list/materials/stackable-material/stackable-material.tsx
Outdated
Show resolved
Hide resolved
JacobArrow
reviewed
Nov 17, 2023
src/apps/loan-list/materials/stackable-material/stackable-material.tsx
Outdated
Show resolved
Hide resolved
JacobArrow
requested changes
Nov 17, 2023
In the stackable material component.
JacobArrow
reviewed
Nov 20, 2023
| openDueDateModal={() => | ||
| openDueDateModal && dueDate && openDueDateModal(dueDate) | ||
| } | ||
| openDueDateModal={() => handleOpenDueDateModal()} |
There was a problem hiding this comment.
Change to openDueDateModal={handleOpenDueDateModal} here and below
There was a problem hiding this comment.
What difference does it make @JacobArrow ?
JacobArrow
reviewed
Nov 20, 2023
src/apps/loan-list/materials/stackable-material/stackable-material.tsx
Outdated
Show resolved
Hide resolved
JacobArrow
approved these changes
Nov 20, 2023
Adamik10
merged commit a0fcf4f
into
danskernesdigitalebibliotek:demo_2023-48-0
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-280
Description
This PR fixes an issue where on the loan list, when clicking on a stacked loans card, only the first material would open in a modal. Now We open group modal.
Screenshot of the result
n/a
Additional comments or questions
n/a