Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of reservation labels (don't merge b4 design) #690

Conversation

spaceo
Copy link
Contributor

@spaceo spaceo commented Nov 17, 2023

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-278
https://reload.atlassian.net/browse/DDFLSBP-279

Description

They were just put in roughly everywhere needed so the different views in group-modal and reservation-list had to be adjusted.

Screenshot of the result

image

Additional comments or questions

Depending on PR in design system.
When the other PR has been merged the dependency to the design system in package.json should be merged.

@spaceo spaceo changed the title Improve rendering of reservation labels Improve rendering of reservation labels (don't merge b4 design) Nov 17, 2023
@Adamik10 Adamik10 self-requested a review November 20, 2023 08:50
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff :)))

@Adamik10 Adamik10 changed the base branch from develop to demo_2023-48-0 November 20, 2023 11:14
They were just put in roughly everywhere needed so the
different views in group-modal and reservation-list had to be adjusted.
@spaceo spaceo force-pushed the DDFLSBP-278-mobil-gruppemodaler-tilpasser-sig-ikke-laengere-mobilvisning branch from 725dfe0 to ca82706 Compare November 21, 2023 08:38
@spaceo spaceo merged commit 18b5aa2 into danskernesdigitalebibliotek:demo_2023-48-0 Nov 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants