Remove typescript-graphql-typed-files-modules #717
Merged
+11
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package does not seem to be used. According to the documentation the package is used by adding typescript-graphql-typed-files-modules as a plugin in the YAML file for graphql-codegen. https://github.com/agendrix/typescript-graphql-typed-files-modules We do not have it declared in dbc-gateway.codegen.yml. Consequenty it does not seem to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package does not seem to be used.
According to the documentation the package is used by adding typescript-graphql-typed-files-modules as a plugin in the YAML file for graphql-codegen. https://github.com/agendrix/typescript-graphql-typed-files-modules
We do not have it declared in dbc-gateway.codegen.yml. Consequenty it does not seem to be used.
Additional comments or questions
It is a bit tricky to remove packages which are only used for codegen and are not tested during standard CI. I think we should be good though.
The reason I add it now is that we have a Dependabot update for the package #713.
With that in mind I only assigned you @spaceo since you are the one who set up the code generation initially.